This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: Andreas Schwab <schwab at linux-m68k dot org>, GNU C Library <libc-alpha at sourceware dot org>, azanella at linux dot vnet dot ibm dot com
- Date: Wed, 3 Sep 2014 14:13:37 -0700 (PDT)
- Subject: Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- Authentication-results: sourceware.org; auth=none
- References: <54006E57 dot 8030800 at redhat dot com> <87y4u7o1yr dot fsf at igel dot home> <20140829215448 dot 6C4972C3A30 at topped-with-meat dot com> <5401A6C1 dot 7090807 at redhat dot com>
> I would like to do this in a future cleanup across all gconv modules,
> after the 2.20 release. For this patch, I went with the existing style
> in the changed files. This also simplifies backporting.
That's certainly fine. If you noticed a thing like that when doing the
change, it's a good idea to mention explicitly in the posting what future
cleanups you intend to do. Without that, people like me are liable to
simply review each line you touched generically for how it should look in
the end.