This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- From: Florian Weimer <fweimer at redhat dot com>
- To: "Carlos O'Donell" <carlos at redhat dot com>, Roland McGrath <roland at hack dot frob dot com>, Andreas Schwab <schwab at linux-m68k dot org>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, azanella at linux dot vnet dot ibm dot com
- Date: Wed, 03 Sep 2014 19:52:35 +0200
- Subject: Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- Authentication-results: sourceware.org; auth=none
- References: <54006E57 dot 8030800 at redhat dot com> <87y4u7o1yr dot fsf at igel dot home> <20140829215448 dot 6C4972C3A30 at topped-with-meat dot com> <5401A6C1 dot 7090807 at redhat dot com> <540743DD dot 9080003 at redhat dot com>
On 09/03/2014 06:37 PM, Carlos O'Donell wrote:
You get an ACK from me to use __builtin_expect for now, since it
also simplified backports of this security bug fix by minimally
touching code.
Thanks, I've committed the change to master.
I am however holding you responsible to cleanup the uses after
2.20 branches >:-)
Sure, let's get 2.20 out soon, so that I don't forget about it. :-)
--
Florian Weimer / Red Hat Product Security