This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- From: Andreas Schwab <schwab at linux-m68k dot org>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, azanella at linux dot vnet dot ibm dot com
- Date: Fri, 29 Aug 2014 15:33:00 +0200
- Subject: Re: [PATCH] Fix crashes on invalid input in IBM gconv modules [BZ #17325]
- Authentication-results: sourceware.org; auth=none
- References: <54006E57 dot 8030800 at redhat dot com>
Florian Weimer <fweimer@redhat.com> writes:
> + if (__builtin_expect (rp2->start == 0xffff, 0) \
Please use either this
> + if (__builtin_expect (ch == 0xffff, 0) \
or this consistently.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."