This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH,Hurd] Fix hang on fork
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Samuel Thibault <samuel dot thibault at gnu dot org>
- Cc: libc-alpha at sourceware dot org, bug-hurd at gnu dot org
- Date: Thu, 28 Aug 2014 13:04:14 -0700 (PDT)
- Subject: Re: [PATCH,Hurd] Fix hang on fork
- Authentication-results: sourceware.org; auth=none
- References: <20140827230625 dot GW3343 at type dot youpi dot perso dot aquilenet dot fr> <20140828182108 dot 799512C3A5D at topped-with-meat dot com> <20140828183157 dot GH3011 at type dot youpi dot perso dot aquilenet dot fr>
> This is what I had put, is some information still missing?
Oh, was that in the message? I must have missed it because I didn't see a
ChangeLog header.
> * sysdeps/mach/hurd/fork.c (__fork): Lock SS->lock around __proc_dostop() call.
Don't use () as if it were part of a function name. Otherwise that is just
right (though it's ok to omit " (__fork)" in a libc file whose file name
matches the function).
> + /* Keep our SS locked while stopping other threads, so they don't get a
> + chance to be having it locked in the copied space. */
I didn't bother to say that this sentence is rather awkward to a native
English speaker: s/to be having it locked/to have it locked/.
The formatting is now correct, so you can go ahead and commit.
Thanks,
Roland