This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v1.1 20/20] Include config.h in MIN-CPPFLAGS
- From: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- To: Stefan Liebler <stli at linux dot vnet dot ibm dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Fri, 22 Aug 2014 19:52:28 +0530
- Subject: Re: [PATCH v1.1 20/20] Include config.h in MIN-CPPFLAGS
- Authentication-results: sourceware.org; auth=none
- References: <20140821175954 dot GA10983 at spoyarek dot pnq dot redhat dot com> <20140822053122 dot GF16835 at spoyarek dot pnq dot redhat dot com> <lt7gnt$du3$1 at ger dot gmane dot org>
On 22 August 2014 19:01, Stefan Liebler <stli@linux.vnet.ibm.com> wrote:
> Hi Siddhesh,
>
> Iæe tested your is_in_module branch on s390x.
Thanks!
> But building the testsuite fails while building nptl_db/db-symbols.v.iT
> because NOT_IN is not defined in structs.def:
> structs.def:81:12: error: missing binary operator before token "("
> #if NOT_IN (libpthread) || TLS_TCB_AT_TP
> ^
>
> The defining NOT_IN to zero of patch 19 is not done, because of patch v1.1
> 20.
>
> patch 19:
> +#ifndef _LIBC
> +# define NOT_IN(lib) (0)
> +#endif
>
> patch v1.1 20:
> + -D_LIBC -include $(common-objpfx)config.h \
>
>
> After changing patch 19 to
> #ifndef NOT_IN
> # define NOT_IN(lib) (0)
> #endif
I think I need to generate libc-modules.h without depending on soversions.i.
> the following tests are failing:
> FAIL: conform/ISO/stdlib.h/conform
> FAIL: conform/ISO11/stdlib.h/conform
> FAIL: conform/ISO99/stdlib.h/conform
> FAIL: conform/POSIX/mqueue.h/conform
> FAIL: conform/POSIX/stdlib.h/conform
> FAIL: conform/POSIX2008/mqueue.h/conform
> FAIL: conform/POSIX2008/stdlib.h/conform
> FAIL: conform/UNIX98/mqueue.h/conform
> FAIL: conform/XOPEN2K/stdlib.h/conform
> FAIL: conform/XOPEN2K8/mqueue.h/conform
> FAIL: conform/XOPEN2K8/stdlib.h/conform
> with either:
>>Namespace violation: "IS_IN"
> or:
OK, that's porobably a good reason to not try to define IS_IN or
NOT_IN and just use _LIBC in the conditionals.
I'll fix these things up and update the branch.
Thanks,
Siddhesh
--
http://siddhesh.in