This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [BZ 14094] Update locale data to Unicode 7.0.0


please fix your mail client so patches are inlined.  or just use `git send-
email` as it'll do everything for you.

your changes to localedata/ChangeLog should be indented with tabs, not spaces.  
there should be no blank lines between each file entry.  there should be a 
blank line after your name though.

the python files need their style fixed.  they should conform to PEP8 and 
shouldn't mix tabs/spaces, and there should be no trailing whitespace.  you 
also shouldn't leave in commented out debug code.  see the existing .py files 
in the tree for more examples.  they also should be python-3 compatible which 
means at least importing the print function from the future module.  also use 
a main() func rather than inlining a lot of code in the __name__ check.

you've left in commented code in gen-unicode-ctype.c ... there shouldn't be.  
your style in there is also broken -- needs to be GNU.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]