This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Added icmp6 options and router preference


On Tue 22 Apr 2014 12:21:16 OndÅej BÃlka wrote:
> On Tue, Apr 22, 2014 at 11:54:56AM +0200, Florian Weimer wrote:
> > On 03/31/2014 12:01 PM, Dan Luedtke wrote:
> > >Hi Florian, OndÅej, @list,
> > >
> > >On Mon, 2014-03-31 at 09:18 +0200, Florian Weimer wrote:
> > >>There is precedent for ND_OPT_ARO instead.
> > >
> > >I am fine with that! Looks better that the long version.
> > 
> > It doesn't seem like this was applied.  Do we need copyright
> > assignment for a change with such limited scope?
> 
> I asked if you have additional comments, you could commit it if you
> want.
> 
> Typically copyrigth assignment is not needed when total changes
> of person are below 15 lines.

well, the diffstat shows that it's more than 2x the number you stated

but the "small line count" is really a simplified rule of thumb for the idea 
that copyright assignment papers are not required when the change is not 
deemed copyrightable.  i think this is such a case as it's merely adding 
defines for existing standards to a public API header.

so if everyone is happy, shall we merge ?
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]