This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Committing patches without review (Re: GNU C Library master sources branch master updated. glibc-2.19-812-g7ee03f0)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>, <jim at meyering dot net>
- Date: Wed, 16 Jul 2014 21:46:22 +0000
- Subject: Re: Committing patches without review (Re: GNU C Library master sources branch master updated. glibc-2.19-812-g7ee03f0)
- Authentication-results: sourceware.org; auth=none
- References: <CAAHN_R2pcGDdfWmrqjx=_GvjwvhQ5wzckkwtN0p4=-7nCVamwQ at mail dot gmail dot com>
On Mon, 14 Jul 2014, Siddhesh Poyarekar wrote:
> Hi Jim,
>
> I noticed that you committed this patch earlier today; that's not how
> we do it in glibc nowadays. There needs to be a review and ack by at
> least another maintainer before a patch makes it in. Some people have
> blanket commit access to parts of the repo, but even they ought to be
> posting a note on libc-alpha with the patch to notify others of the
> change.
>
> As for the change itself, it seems fine to me, but please also mention
> the fixed bug in NEWS and close the bug.
Ping. It appears the bug still hasn't been closed and still isn't
mentioned in the list of fixed bugs in NEWS.
--
Joseph S. Myers
joseph@codesourcery.com