This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Committing patches without review (Re: GNU C Library master sources branch master updated. glibc-2.19-812-g7ee03f0)
- From: Allan McRae <allan at archlinux dot org>
- To: Siddhesh Poyarekar <siddhesh dot poyarekar at gmail dot com>, meyering at sourceware dot org
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Mon, 14 Jul 2014 22:10:41 +1000
- Subject: Re: Committing patches without review (Re: GNU C Library master sources branch master updated. glibc-2.19-812-g7ee03f0)
- Authentication-results: sourceware.org; auth=none
- References: <CAAHN_R2pcGDdfWmrqjx=_GvjwvhQ5wzckkwtN0p4=-7nCVamwQ at mail dot gmail dot com>
On 14/07/14 21:35, Siddhesh Poyarekar wrote:
> Hi Jim,
>
> I noticed that you committed this patch earlier today; that's not how
> we do it in glibc nowadays. There needs to be a review and ack by at
> least another maintainer before a patch makes it in. Some people have
> blanket commit access to parts of the repo, but even they ought to be
> posting a note on libc-alpha with the patch to notify others of the
> change.
>
> As for the change itself, it seems fine to me, but please also mention
> the fixed bug in NEWS and close the bug.
>
> Thanks,
> Siddhesh
> [1] https://sourceware.org/glibc/wiki/MAINTAINERS
>
I think this is at least partly my fault. Jim replied to my freeze
email directly asking if the glibc-2.20 freeze was still slushy. My
reply was that the change could still be committed and looked like it
fell into the obvious category. I end with "I'm assuming you have
commit access - if not post to libc-alpha." I should have been clearer
that the committed patch still needed posted to the list.
Allan