This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- From: Chris Metcalf <cmetcalf at tilera dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>, Will Newton <will dot newton at linaro dot org>
- Cc: Roland McGrath <roland at hack dot frob dot com>, libc-alpha <libc-alpha at sourceware dot org>
- Date: Fri, 27 Jun 2014 16:26:57 -0400
- Subject: Re: [PATCH v2] Fix Wundef warning for MEMCPY_OK_FOR_FWD_MEMMOVE
- Authentication-results: sourceware.org; auth=none
- References: <20140626185412 dot GA1826 at spoyarek dot pnq dot redhat dot com> <20140626190423 dot 572732C3993 at topped-with-meat dot com> <20140627092109 dot GD4477 at spoyarek dot pnq dot redhat dot com> <CANu=Dmi2W9jK8+jjtSms3Y0KTuY20UnvLTz_0iTOOYnedT0uzg at mail dot gmail dot com> <20140627171326 dot GE4477 at spoyarek dot pnq dot redhat dot com>
On 6/27/2014 1:13 PM, Siddhesh Poyarekar wrote:
I've moved the macro definition to memcopy.h with tile overriding the
definition in its memcopy.h. This also allows us to get rid of the
tile-specific memmove.c. The tile bit is untested, so I'll need Chris
to verify that it doesn't cause any problems. The code is unchanged
on x86_64.
Siddhesh
* sysdeps/generic/memcopy.h: Define MEMCPY_OK_FOR_FWD_MEMMOVE.
* sysdeps/tile/memcopy.h: Redefine MEMCPY_OK_FOR_FWD_MEMMOVE.
* sysdeps/tile/tilegx/memmove.c: Remove file.
The problem with this is that tilepro's memmove.c can't use the optimization,
just tilegx, thus the placement in sysdeps/tile/tilegx/memmove.c. So with an
#ifdef __tilegx__, and copying in the comment from the old memmove.c,
this would seem to be OK.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com