This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix Wundef warning for DEBUG in mktime


On Thu, Jun 26, 2014 at 10:19:35AM -0700, Roland McGrath wrote:
> How close are we to mktime being harmonized with gnulib already?

Not far at all; there's just one change that should bring us in sync
with gnulib.  Patch below with the right attribution.

> If we're already there, then please coordinate this change with them.

OK.

Siddhesh

2014-06-26  Paul Eggert  <eggert@cs.ucla.edu>

	* time/mktime.c (leapyear): Remove inline keyword.

diff --git a/time/mktime.c b/time/mktime.c
index a4a2d58..077f9c4 100644
--- a/time/mktime.c
+++ b/time/mktime.c
@@ -142,7 +142,7 @@ verify (twos_complement_arithmetic,
 verify (base_year_is_a_multiple_of_100, TM_YEAR_BASE % 100 == 0);
 
 /* Return 1 if YEAR + TM_YEAR_BASE is a leap year.  */
-static inline int
+static int
 leapyear (long_int year)
 {
   /* Don't add YEAR to TM_YEAR_BASE, as that might overflow.

Attachment: pgp3h4J0N6BjX.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]