This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [COMMITTED PATCH] Add missing #include in get-rounding-mode.h
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roland McGrath <roland at hack dot frob dot com>
- Cc: Will Newton <will dot newton at linaro dot org>, "GNU C. Library" <libc-alpha at sourceware dot org>
- Date: Tue, 24 Jun 2014 20:35:05 +0000
- Subject: Re: [COMMITTED PATCH] Add missing #include in get-rounding-mode.h
- Authentication-results: sourceware.org; auth=none
- References: <20140623210855 dot C470A2C39AB at topped-with-meat dot com> <CANu=Dmha4wxoGk_gNq5UWiHOo_VkpuRyNUsaaL4tT60EhPZDxg at mail dot gmail dot com> <20140624201704 dot 40AEE2C39D2 at topped-with-meat dot com>
On Tue, 24 Jun 2014, Roland McGrath wrote:
> The nest of implicit includes is beyond anyone's keeping track of, so
> miscellaneous cleanups can have this effect and it's not a big deal to
> fix it up. It could well have been someone else's change after yours
> that somehow made the difference. Everyone should just remember to look
> for warnings. (It will get much easier to notice them again when we clean
> up the -Wundef fallout.)
Once the -Wundef fallout is resolved, I hope we can move to building with
-Werror by default (with some suitable policy about using
-Wno-error=whatever or -Wno-whatever when warnings, possibly depending on
the compiler version, seem hard to fix - probably including comments about
what the warnings are and what platforms / GCC versions they are seen
with, to help guide future review of such -Wno- settings; existing -Wno-
uses could also do with such review).
--
Joseph S. Myers
joseph@codesourcery.com