This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 6/9][v2] Alpha - Remove alpha lowlevellock.h


On 06/10/2014 09:15 AM, Bernard Ogden wrote:
> Great. Here's a patch to remove it instead.
> 
> I forgot to mention the changes this causes for alpha -
> 
> lll_futex_timed_wait_bitset now mainpulates its return value
> through the usual macros - as callers do more than just compare
> return value to 0, it may have been a bug that it was not doing
> so before.

Yes, it looks like it.  It would have been returning a positive errno before,
as opposed to -errno that others return.

>     
> lll_futex_timed_wait_requeue_pi now calls INTERNAL_SYSCALL_ERROR_P
> on the return value. This function only has one caller, and that
> caller just compares return value to 0, so the behaviour is
> equivalent.

True.

> 	* sysdeps/unix/sysv/linux/alpha/lowlevellock.h: Remove file.

Ok.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]