This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
- From: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: GNU C Library <libc-alpha at sourceware dot org>
- Date: Tue, 3 Jun 2014 15:56:29 +0400
- Subject: Re: [PATCH 1/25] Remove nested functions: crypt/md5-crypt.c
- Authentication-results: sourceware.org; auth=none
- References: <CAGQ9bdzqT1EyXYMwACrHpPU=vPjM_b72LJRjb7BW_OzJRXG3bw at mail dot gmail dot com> <20140520131314 dot GB14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdw=-pzbi00gn5t_W8pXBjU0edFvLGMNUc+o=g9og=f9+Q at mail dot gmail dot com> <20140522145906 dot GX14500 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdzL=EXg0RrJ6xs5n7uW6xWj6Mgrc5e=WWZ25-07k8ThGQ at mail dot gmail dot com> <CAGQ9bdzXbO3QuuS=8-m2HqxYNyahMpTRmfGH90SMZ3j2oozU6g at mail dot gmail dot com> <20140602180811 dot GC9145 at spoyarek dot pnq dot redhat dot com> <CAGQ9bdzTqWTU3EQgpt_Ptbdu=osKw8yQpYuD6Rdd7mSa0W25yw at mail dot gmail dot com> <20140603111409 dot GM9145 at spoyarek dot pnq dot redhat dot com>
Thanks!
On Tue, Jun 3, 2014 at 3:14 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
> On Tue, Jun 03, 2014 at 12:28:35PM +0400, Konstantin Serebryany wrote:
>> On Mon, Jun 2, 2014 at 10:08 PM, Siddhesh Poyarekar <siddhesh@redhat.com> wrote:
>> > On Mon, Jun 02, 2014 at 08:50:51AM +0400, Konstantin Serebryany wrote:
>> >> Any comment on this patch?
>> >
>> > It results in a bunch of build warnings with gcc. Please fix those.
>> Indeed so, needed one extra include. Fixed, please check the new patch.
>>
>> Did you just see the warnings with your eyes, or do you use a special
>> configure switch or some such to turn them into errors?
>>
>
> TBH I just happened to see it when I was pulling in your patch. I
> noticed a warning I had introduced earlier and then the warnings you
> introduced :)
>
> I have pushed your patch now.
>
> Thanks,
> Siddhesh