This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Add FE_NOMASK_ENV return value test


> > From: Joseph Myers wrote:
> > On Fri, 23 May 2014, Wilco wrote:
> >
> > > This patch rewrites feupdateenv to improve performance by avoiding
> > > unnecessary FPSCR reads/writes and to fix bug 16918
> > > (https://sourceware.org/bugzilla/show_bug.cgi?id=16918).
> >
> > It would be desirable to add an architecture-independent testcase that, if
> > FE_NOMASK_ENV is defined and feupdateenv (FE_NOMASK_ENV) succeeds, the
> > exceptions are then enabled as indicated by fegetexcept (or by getting
> > SIGFPE, as test-fenv.c tests various cases, but a test using fegetexcept
> > is simpler to write).  (It's best for this to be a new test rather than
> > adding to the things in test-fenv.c.)

This patch adds a new test to ensure the return values of fesetenv, feupdateenv 
and feenbleexcept are correct when FE_NOMASK_ENV is not supported. This ensures 
BZ16918/BZ17009 remain fixed.

OK?

Wilco

ChangeLog:
2014-06-02  Wilco  <wdijkstr@arm.com>

	* math/test-fenv-return.c: New file. Test FE_NOMASK_ENV return values.
	* math/Makefile: Add new test test-fenv-return.

Attachment: Add-fenv-return-test.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]