This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [1/3] elf/dl-lookup.c: Move STB_GNU_UNIQUE handling to a function
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Fri, 16 May 2014 23:02:53 +0200
- Subject: Re: [1/3] elf/dl-lookup.c: Move STB_GNU_UNIQUE handling to a function
- Authentication-results: sourceware.org; auth=none
- References: <1397230188-14581-1-git-send-email-will dot newton at linaro dot org>
On Fri, Apr 11, 2014 at 04:29:46PM +0100, Will Newton wrote:
> Move handling of STB_GNU_UNIQUE symbols to a separate function
> from do_lookup_x in order to make the code more readable.
>
> The new function gets inlined with gcc 4.8 on ARM and the
> do_lookup_x code becomes a few bytes smaller.
>
> ChangeLog:
>
> 2014-04-02 Will Newton <will.newton@linaro.org>
>
> * elf/dl-lookup.c (do_lookup_unique): New function.
> (do_lookup_x): Move STB_GNU_UNIQUE handling code
> to a separate function.
>
Looks ok for me.