This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v1.2] Deprecate malloc_(sg)et state.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: Roland McGrath <roland at hack dot frob dot com>, <libc-alpha at sourceware dot org>
- Date: Fri, 16 May 2014 20:32:47 +0000
- Subject: Re: [PATCH v1.2] Deprecate malloc_(sg)et state.
- Authentication-results: sourceware.org; auth=none
- References: <20140304123542 dot GA12375 at domone dot podge> <20140314170541 dot EF58A74495 at topped-with-meat dot com> <20140324092658 dot GA3973 at domone dot podge> <20140324221550 dot 649EA74484 at topped-with-meat dot com> <20140428110349 dot GA23227 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1404281454271 dot 16435 at digraph dot polyomino dot org dot uk> <20140428150007 dot GA5597 at domone dot podge> <Pine dot LNX dot 4 dot 64 dot 1404281506290 dot 16435 at digraph dot polyomino dot org dot uk> <20140516184537 dot GA5856 at domone dot podge>
On Fri, 16 May 2014, Ondrej Bilka wrote:
> On Mon, Apr 28, 2014 at 03:07:20PM +0000, Joseph S. Myers wrote:
> > On Mon, 28 Apr 2014, Ondrej Bilka wrote:
> >
> > > On Mon, Apr 28, 2014 at 02:55:18PM +0000, Joseph S. Myers wrote:
> > > > On Mon, 28 Apr 2014, Ondrej Bilka wrote:
> > > >
> > > > > + malloc_get_state = dlvsym (RTLD_NEXT, "malloc_get_state", "GLIBC_2.2.5");
> > > > > + malloc_set_state = dlvsym (RTLD_NEXT, "malloc_set_state", "GLIBC_2.2.5");
> > > >
> > > > That's not correct. GLIBC_2.2.5 is what GLIBC_2.0 maps to on x86_64, but
> > > > on other architectures it maps to other versions; you need the correct
> > > > version depending on the architecture.
> > > >
> > > Any macro for that?
> >
> > Try stringizing the expansion of VERSION_libc_GLIBC_2_0 from
> > abi-versions.h.
> >
> Here is new version. Is there some other concern?
This sort of feature change should include an addition to the NEWS file.
--
Joseph S. Myers
joseph@codesourcery.com