This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove second argument from TLS_INIT_TP macro


> Roland McGrath <roland@hack.frob.com> writes:
> 
> >> --- a/nptl/sysdeps/i386/tls.h
> >> +++ b/nptl/sysdeps/i386/tls.h
> >> @@ -195,7 +195,7 @@ union user_desc_init
> >>  /* Code to initially initialize the thread pointer.  This might need
> >>     special attention since 'errno' is not yet available and if the
> >>     operation can cause a failure 'errno' must not be touched.  */
> >> -# define TLS_INIT_TP(thrdescr, secondcall) \
> >> +# define TLS_INIT_TP(thrdescr) \
> >>    ({ void *_thrdescr = (thrdescr);					      \
> >>       tcbhead_t *_head = _thrdescr;					      \
> >>       union user_desc_init _segdescr;					      \
> >> @@ -208,10 +208,7 @@ union user_desc_init
> >>       INIT_SYSINFO;							      \
> >>  									      \
> >>       /* The 'entry_number' field.  Let the kernel pick a value.  */	      \
> >> -     if (secondcall)							      \
> >> -       _segdescr.vals[0] = TLS_GET_GS () >> 3;				      \
> >> -     else								      \
> >> -       _segdescr.vals[0] = -1;						      \
> >> +     _segdescr.vals[0] = -1;						      \
> >
> > Please leave a comment behind explaining what -1 means here.
> 
> ??? I didn't remove the comment.

OK.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]