This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #16877] Fix typo in nscd/selinux.c
- From: Will Newton <will dot newton at linaro dot org>
- To: OndÅej BÃlka <neleai at seznam dot cz>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Tue, 6 May 2014 09:26:01 +0100
- Subject: Re: [PATCH][BZ #16877] Fix typo in nscd/selinux.c
- Authentication-results: sourceware.org; auth=none
- References: <20140427181904 dot GA31159 at domone dot podge>
On 27 April 2014 19:19, OndÅej BÃlka <neleai@seznam.cz> wrote:
>
> This bug is another report of typo in code. A perm variable
> is unitialized so there could be spurious error message
> depending how gcc optimizes this. This could be changed into
> intended check as below.
>
> OK to commit this?
>
> [BZ #16877]
> * nscd/selinux.c (nscd_request_avc_has_perm): Check if there is
> nscd security class.
This looks ok to me and fixes the build warning.
> diff --git a/nscd/selinux.c b/nscd/selinux.c
> index 9a8a5a8..eaed6dd 100644
> --- a/nscd/selinux.c
> +++ b/nscd/selinux.c
> @@ -372,7 +372,7 @@ nscd_request_avc_has_perm (int fd, request_type req)
> /* Get the security class for nscd. If this fails we will likely be
> unable to do anything unless avc_deny_unknown is 0. */
> sc_nscd = string_to_security_class ("nscd");
> - if (perm == 0 && avc_deny_unknown == 1)
> + if (sc_nscd == 0 && avc_deny_unknown == 1)
> dbg_log (_("Error getting security class for nscd."));
>
> /* Convert permission to AVC bits. */
--
Will Newton
Toolchain Working Group, Linaro