This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- From: "Michael Kerrisk (man-pages)" <mtk dot lists at gmail dot com>
- To: David Miller <davem at davemloft dot net>, neleai at seznam dot cz
- Cc: mtk dot manpages at gmail dot com, schwab at linux-m68k dot org, libc-alpha at sourceware dot org, "Michael Kerrisk (gmail)" <mtk dot manpages at gmail dot com>
- Date: Wed, 30 Apr 2014 10:28:53 +0200
- Subject: Re: [PATCH v2][BZ 16852] Do not clobber recvmmsg argument.
- Authentication-results: sourceware.org; auth=none
- References: <20140428152937 dot GA1736 at domone dot podge> <87mwf5zcl3 dot fsf at igel dot home> <20140428160420 dot GA23142 at domone dot podge> <20140428 dot 130122 dot 2188782190759376374 dot davem at davemloft dot net>
- Reply-to: mtk dot manpages at gmail dot com
On 04/28/2014 07:01 PM, David Miller wrote:
> From: Ondřej Bílka <neleai@seznam.cz>
> Date: Mon, 28 Apr 2014 18:04:20 +0200
>
>> * sysdeps/unix/sysv/linux/recvmmsg.c (recvmmsg): Do not clobber
>> timeout argument.
>
> It is extremely unfortunate if we've defined this argument as const,
> now you are making it so that the user has no mechanism to get the
> updated timeval other than to define their own syscall stubs.
>
> This is doubly unfortunately since there is absolutely no reason for
> us to have defined the interface different from what the kernel
> actually provides.
Agreed. Surely, the right fix here is simply to remove the "const"
qualifier from the glibc API?
Cheers,
Michael