This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
[PATCH v2 2/3] stdlib/tst-setcontext.c: Check for clobbering of signal stack
- From: Will Newton <will dot newton at linaro dot org>
- To: libc-alpha at sourceware dot org
- Date: Tue, 1 Apr 2014 12:32:46 +0100
- Subject: [PATCH v2 2/3] stdlib/tst-setcontext.c: Check for clobbering of signal stack
- Authentication-results: sourceware.org; auth=none
- References: <1396351967-1952-1-git-send-email-will dot newton at linaro dot org>
On aarch64 calling swapcontext clobbers the state of the signal
stack (BZ #16629). Check that the address and size of the signal
stack before and after the call to swapcontext remains the same.
ChangeLog:
2014-04-01 Will Newton <will.newton@linaro.org>
[BZ #16629]
* stdlib/tst-setcontext.c: Include signal.h.
(main): Check that the signal stack before and
after swapcontext is the same.
---
stdlib/tst-setcontext.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
Changes in v2:
- Fixed changelog bug reference
diff --git a/stdlib/tst-setcontext.c b/stdlib/tst-setcontext.c
index ac9deb1..55984a4 100644
--- a/stdlib/tst-setcontext.c
+++ b/stdlib/tst-setcontext.c
@@ -16,6 +16,7 @@
<http://www.gnu.org/licenses/>. */
#include <errno.h>
+#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@@ -144,6 +145,9 @@ main (void)
atexit (check_called);
char st1[32768];
+ stack_t stack_before, stack_after;
+
+ sigaltstack(NULL, &stack_before);
puts ("making contexts");
if (getcontext (&ctx[1]) != 0)
@@ -207,6 +211,8 @@ main (void)
puts ("back at main program");
back_in_main = 1;
+ sigaltstack(NULL, &stack_after);
+
if (was_in_f1 == 0)
{
puts ("didn't reach f1");
@@ -218,6 +224,21 @@ main (void)
exit (1);
}
+ /* Check sigaltstack state is not clobbered as in BZ #16629. */
+ if (stack_before.ss_sp != stack_after.ss_sp)
+ {
+ printf ("stack ss_sp mismatch: %p %p\n",
+ stack_before.ss_sp, stack_after.ss_sp);
+ exit (1);
+ }
+
+ if (stack_before.ss_size != stack_after.ss_size)
+ {
+ printf ("stack ss_size mismatch: %zd %zd\n",
+ stack_before.ss_size, stack_after.ss_size);
+ exit (1);
+ }
+
puts ("test succeeded");
return 0;
}
--
1.8.1.4