This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Set errno for atan2 underflow (bug 16349)


On 03/25/2014 05:07 PM, Joseph S. Myers wrote:
> This patch fixes bug 16349, missing errno setting for atan2 underflow,
> by adding appropriate checks to the existing wrappers.  (As in other
> cases, the __kernel_standard support for calling matherr is considered
> to be for existing code expecting existing rules for what's considered
> an error, even if those don't correspond to a general logical scheme
> for what counts as what kind of error, so __set_errno calls are added
> directly without any changes to __kernel_standard.)
> 
> Tested x86_64 and x86.
> 
> (auto-libm-test-out diffs omitted below.)
> 
> 2014-03-25  Joseph Myers  <joseph@codesourcery.com>
> 
> 	[BZ #16349]
> 	* math/w_atan2.c: Include <errno.h>.
> 	(__atan2): Set errno for result underflowing to zero.
> 	* math/w_atan2f.c: Include <errno.h>.
> 	(__atan2f): Set errno for result underflowing to zero.
> 	* math/w_atan2l.c: Include <errno.h>.
> 	(__atan2l): Set errno for result underflowing to zero.
> 	* math/auto-libm-test-in: Don't allow missing errno for some atan2
> 	tests.
> 	* math/auto-libm-test-out: Regenerated.

ok, thanks,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]