This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Avoid overlapping addresses to stpcpy calls in nscd (BZ #16760)


On Thu, Mar 27, 2014 at 08:22:54PM +0100, OndÅej BÃlka wrote:
> > > Fix this by using memmove instead of stpcpy.  Tested x86_64 using
> > > various combinations of triplets (including NULL and non-NULL ones) to
> > > verify that this works correctly and there are no regressions.
> >
> This could work only with additional assertion that we do not move host
> forward otherwise it could overwrite user.

If the host, user and domain are out of order, they are copied in
order into a separate area in the buffer before the memmove.  If you
think there's something else that could move host forward then I don't
understand and you'll have to elaborate a bit.

Siddhesh

Attachment: pgpFHjy8lfObN.pgp
Description: PGP signature


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]