Re: [PATCH 2/2] ARM: Improve fenv implementation

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Tue, 25 Mar 2014, Wilco wrote:

> +  /* Write new exceptions if changed.  */
> +  if (__glibc_unlikely (new_fpscr != fpscr))

I'm very doubtful of such __glibc_unlikely uses in these functions.  They 
may make sense for inlines used in other libm functions (libm functions 
are normally called in round-to-nearest, other modes are unlikely) - but 
there is no particular reason to believe that no-change expectations (or 
other such expectations on what valid arguments are used) are correct for 
direct use of <fenv.h> functions.  (It might be reasonable to mark error 
paths, such as invalid rounding modes, with __glibc_unlikely, but I doubt 
that's particularly useful either.)

>    /* Fail if a VFP unit isn't present.  */
>    if (!ARM_HAVE_VFP)
> -    return 1;
> +     return 1;

It makes no sense to have such indentation changes in this patch.  Make 
sure patch 1 gets the indentation right for everything it changes and then 
that patch 2 doesn't change any correct indentation to wrong indentation, 
and resend fixed versions of both patches.

-- 
Joseph S. Myers
joseph@codesourcery.com