This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Account for alloca use when collecting interface addresses
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: <libc-alpha at sourceware dot org>
- Date: Tue, 25 Mar 2014 12:20:27 +0000
- Subject: Re: [PATCH] Account for alloca use when collecting interface addresses
- Authentication-results: sourceware.org; auth=none
- References: <mvm61n3puag dot fsf at hawking dot suse dot de> <Pine dot LNX dot 4 dot 64 dot 1403242117180 dot 1129 at digraph dot polyomino dot org dot uk> <mvm1txqogt2 dot fsf at hawking dot suse dot de>
On Tue, 25 Mar 2014, Andreas Schwab wrote:
> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>
> > I'm seeing compilation warnings (we clearly need to move to a -Werror
> > default, I see a recent patch of mine introduced some as well...):
> >
> > ../sysdeps/unix/sysv/linux/check_pf.c:326:20: warning: 'in6ailist' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Thanks for catching that. This is embarrassing. I really need to
> improve my testing, especially with the recent increase in warning spam.
> How about this?
>
> * sysdeps/unix/sysv/linux/check_pf.c (make_request): Add out_fail2
> label to be used after in6ailist is initialized.
Looks right to me.
--
Joseph S. Myers
joseph@codesourcery.com