This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Will Newton <will dot newton at linaro dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Mon, 17 Mar 2014 11:28:18 -0700 (PDT)
- Subject: Re: [PATCH 1/7] Fix __PTHREAD_MUTEX_HAVE_ELISION -Wundef warning
- Authentication-results: sourceware.org; auth=none
- References: <1395059004-20960-1-git-send-email-will dot newton at linaro dot org>
This and some of the others do the style of fix that would be obvious to
someone who hadn't read the discussion here about -Wundef. I think that in
the general case that is worth than nothing. Please focus on what you can
fix using typo-proof methods, and discuss explicitly the few cases where
using #idef-like methods is actually necessary.