This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Fix dwarf2 unwinding through futex functions v2
- From: Andi Kleen <andi at firstfloor dot org>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: Andi Kleen <andi at firstfloor dot org>, libc-alpha at sourceware dot org
- Date: Mon, 17 Mar 2014 18:04:02 +0100
- Subject: Re: [PATCH] Fix dwarf2 unwinding through futex functions v2
- Authentication-results: sourceware.org; auth=none
- References: <1383870168-31055-1-git-send-email-andi at firstfloor dot org> <877g895w10 dot fsf at tassilo dot jf dot intel dot com> <5318A23C dot 6060301 at redhat dot com>
> My last comment was November 11th 2013:
> https://sourceware.org/ml/libc-alpha/2013-11/msg00194.html
> ~~~
> I'm OK with this patch as long as you've tried to at least debug a
> program built with these new libpthread code and you can unwind through
> them. That is to say build some application with the newly built glibc
> e.g. -Wl,--dynamic-linker=xxx -Wl,-rpath=xxx:xxx, and you can break on
> some instruction deep in the lock sequence and backtrace correctly.
> ~~~
>
> If you did this verification then I'm happy with you checking it in.
Just revisiting this sorry.
I did the test originally. However I don't have commit access to the glibc
git repository, so someone else would need to check it in.
-Andi