This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/3] PowerPC: remove wrong roundl implementation for PowerPC64


On 14-03-2014 10:54, Adhemerval Zanella wrote:
> The roundl assembly implementation
> (sysdeps/powerpc/powerpc64/fpu/s_roundl.S)
> returns wrong results for some inputs where first double is a exact
> integer and the precision is determined by second long double.
>
> Checking on implementation comments and history, I am very confident the
> assembly implementation was based on a version before commit
> 5c68d401698a58cf7da150d9cce769fa6679ba5f that fixes BZ#2423 (Errors in
> long double (ldbl-128ibm) rounding functions in glibc-2.4).
>
> By just removing the implementation and make the build select
> sysdeps/ieee754/ldbl-128ibm/s_roundl.c instead fixes the failing math.
>
> Fixes BZ#16707.
>
> Test on PPC64 and PPC64LE. If no one opposes it, I'll commit in a couple
> of hours.
>

Pushed as 98fb27a373f37554232e0060eef1a5bb00a07eb0 with the LDBL_MANT_DIG guards.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]