This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Remove nested function in elf/dl-lookup.c.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Carlos O'Donell <carlos at redhat dot com>
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>, GNU C Library <libc-alpha at sourceware dot org>, Roland McGrath <roland at hack dot frob dot com>
- Date: Wed, 19 Feb 2014 14:06:50 +0100
- Subject: Re: [PATCH] Remove nested function in elf/dl-lookup.c.
- Authentication-results: sourceware.org; auth=none
- References: <52FBDC5F dot 4010908 at redhat dot com> <Pine dot LNX dot 4 dot 64 dot 1402122049000 dot 12558 at digraph dot polyomino dot org dot uk> <52FBE74C dot 4070805 at redhat dot com>
On Wed, Feb 12, 2014 at 04:27:40PM -0500, Carlos O'Donell wrote:
> On 02/12/2014 03:50 PM, Joseph S. Myers wrote:
> > This patch loses the call to ELF_MACHINE_SYM_NO_MATCH that was previously
> > in check_match, and also needs to update the comment on the default
> > definition of ELF_MACHINE_SYM_NO_MATCH to reflect that check_match is no
> > longer a nested function.
>
> I have thrown away the existing refactoring and started again,
> and then compared my new version to the old version to ensure
> that previous testing would still be valid.
>
> This should catch any changes since the last time I refactored.
> I had included Ondrej's changes but had not noticed your changes.
> Git had given me a merge warning for Ondrej's changes for
> __glibc_*likely, but not yours, perhaps I did something wrong there.
>
> Either way I've rested the following and it looks good.
>
> OK?
>
I am ok with this.