This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Added missing ICMPv6 flags and option
- From: "Carlos O'Donell" <carlos at redhat dot com>
- To: Florian Weimer <fweimer at redhat dot com>, Dan LÃdtke <maildanrl at gmail dot com>, libc-alpha at sourceware dot org
- Cc: Dan Luedtke <danrl at danrl dot de>
- Date: Wed, 12 Feb 2014 16:14:40 -0500
- Subject: Re: [PATCH] Added missing ICMPv6 flags and option
- Authentication-results: sourceware.org; auth=none
- References: <1392230153-23499-1-git-send-email-danrl at danrl dot de> <52FBC7DD dot 8020309 at redhat dot com> <CAAfuxnK0eAA1mA_fxhO4Oz9hWiV4yJ6FrZOGDC4j+1uv0OXHFQ at mail dot gmail dot com> <52FBD8BC dot 4020805 at redhat dot com> <52FBDEFE dot 9050302 at redhat dot com>
On 02/12/2014 03:52 PM, Florian Weimer wrote:
> On 02/12/2014 09:25 PM, Carlos O'Donell wrote:
>
>> I'll let Florian comment on the other points.
>
> I already replied offlist:
>
> I looked a bit around and it seems the BSDs already have these
> constants under slightly different names, ND_RA_FLAG_RTPREF_LOW etc.,
> plus _MASK and _RSV constants. This might be sufficient reason to
> include these constants.
Right, we need a standard set of defines.
Do these constants exist in the Linux kernel?
Would a sensible person reading the RFCs come up with the same constant names?
Cheers,
Carlos.