This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][BZ #16549] Add sanity check for condvar alignment.
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Florian Weimer <fweimer at redhat dot com>
- Cc: OndÅej BÃlka <neleai at seznam dot cz>, <libc-alpha at sourceware dot org>
- Date: Tue, 11 Feb 2014 22:44:58 +0000
- Subject: Re: [RFC][BZ #16549] Add sanity check for condvar alignment.
- Authentication-results: sourceware.org; auth=none
- References: <20140211124346 dot GA31165 at domone dot podge> <52FA4AC2 dot 1070400 at redhat dot com>
On Tue, 11 Feb 2014, Florian Weimer wrote:
> I think the real issue here is our lack of error checking for the futex system
> call. strace on the test case shows this:
I'm not sure what we would do with an error here. Cf
<https://sourceware.org/glibc/wiki/Style_and_Conventions#Invalid_pointers>
noting that a crash or assertion failure on an invalid NULL pointer is
better than returning an error value that would likely be ignored by the
buggy caller (although it's not obvious to me that diagnosing a misaligned
pointer through an assertion is worthwhile anyway).
--
Joseph S. Myers
joseph@codesourcery.com