This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [RFC][PATCH 1/2] fcntl.h: add new definitions for file-private lock cmd values
- From: Roland McGrath <roland at hack dot frob dot com>
- To: Jeff Layton <jlayton at redhat dot com>
- Cc: libc-alpha at sourceware dot org, linux-fsdevel at vger dot kernel dot org
- Date: Tue, 11 Feb 2014 13:49:15 -0800 (PST)
- Subject: Re: [RFC][PATCH 1/2] fcntl.h: add new definitions for file-private lock cmd values
- Authentication-results: sourceware.org; auth=none
- References: <1392145436-13983-1-git-send-email-jlayton at redhat dot com> <1392145436-13983-2-git-send-email-jlayton at redhat dot com>
> +2014-02-11 Jeff Layton <jlayton@redhat.com>
> +
> + * add new fcntl cmd macros for file-private locks
Proper format is:
* sysdeps/unix/sysv/linux/bits/fcntl-linux.h
(F_GETLKP, F_SETLKP, F_SETLKPW): New macros.
> +/*
> + * fd "private" POSIX locks.
> + *
> + * Usually POSIX locks held by a process are released on *any* close and are
> + * not inherited across a fork().
Use GNU style for comments, as you see elsewhere in the file. Use two
spaces between sentences. Don't use "function()" when referring to a
function, just the name.
> +#ifndef F_GETLKP
> +# define F_GETLKP 36
> +# define F_SETLKP 37
> +# define F_SETLKPW 38
> +#endif
These need to be protected by #ifdef __USE_GNU.