This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 4 Feb 2014 14:53:55 +0530
- Subject: Re: [PATCH][BZ #16398] Fix infinite loop in ftell when writing wide char data
- Authentication-results: sourceware.org; auth=none
- References: <20140131051923 dot GL2149 at spoyarek dot pnq dot redhat dot com> <20140131192607 dot 05D5474430 at topped-with-meat dot com> <20140203095340 dot GE5209 at spoyarek dot pnq dot redhat dot com> <1632870 dot EN9EMv2yfz at vapier>
On Tue, Feb 04, 2014 at 03:48:13AM -0500, Mike Frysinger wrote:
> On Monday, February 03, 2014 15:23:40 Siddhesh Poyarekar wrote:
> > --- /dev/null
> > +++ b/libio/tst-ftell-partial-wide.c
> >
> > +/* Defined in test-skeleton.c. */
> > +static int create_temp_file (const char *base, char **filename);
>
> ugh. it makes more sense imo (and is safer) to declare do_test static here,
> then move the TEST_FUNCTION define and test-skeleton.c include here. that way
> you aren't copying & pasting content from test-skeleton.c here.
OK, I'll make that change.
On Tue, Feb 04, 2014 at 09:55:58AM +0100, Andreas Schwab wrote:
> > Or do you want me to find out which character that is? It'll be a
> > fair bit of work...
> C-u C-x = will tell you.
Thanks.
Siddhesh