This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH v2 1/3] Fix __check_pf()/make_request() stack overflow segfault (convert to malloc)
- From: "Banerjee, Debabrata" <dbanerje at akamai dot com>
- To: Ondřej Bílka <neleai at seznam dot cz>, "Pengcheng dot Chen at gmail dot com" <Pengcheng dot Chen at gmail dot com>
- Cc: "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Carlos O'Donell <carlos at redhat dot com>
- Date: Thu, 16 Jan 2014 17:58:31 -0500
- Subject: Re: [PATCH v2 1/3] Fix __check_pf()/make_request() stack overflow segfault (convert to malloc)
- Authentication-results: sourceware.org; auth=none
- References: <524E4504 dot 6050603 at redhat dot com> <1383268213-14349-1-git-send-email-dbanerje at akamai dot com> <20140116225341 dot GA23189 at domone dot podge>
On 1/16/14 5:53 PM, "Ondřej Bílka" <neleai@seznam.cz> wrote:
>On Thu, Oct 31, 2013 at 09:10:11PM -0400, Debabrata Banerjee wrote:
>> Tested calls to getaddrinfo() with 64k+ local IPv4 and IPv6 addresses.
>>
>> Changelog:
>>
>> 2013-10-31 Debabrata Banerjee <dbanerje@akamai.com>
>>
>
>As that patch was quite large and there is not much time if we want this
>in 2.19 we should use a simpler patch. I wrote new patch that uses
>malloc instead.
Sorry I haven't had time to look into refactoring this patch more. However
Pengcheng has volunteered to clean it up in whatever way is acceptable.
The caveat with using malloc is that I would expect it to be significantly
slower than alloca, but someone can benchmark that. I believe this is a
hot path.
-Deb