This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v2 1/3] Fix __check_pf()/make_request() stack overflow segfault (convert to malloc)


On 1/16/14 5:53 PM, "Ondřej Bílka" <neleai@seznam.cz> wrote:

>On Thu, Oct 31, 2013 at 09:10:11PM -0400, Debabrata Banerjee wrote:
>> Tested calls to getaddrinfo() with 64k+ local IPv4 and IPv6 addresses.
>> 
>> Changelog:
>> 
>> 2013-10-31  Debabrata Banerjee  <dbanerje@akamai.com>
>> 
>
>As that patch was quite large and there is not much time if we want this
>in 2.19 we should use a simpler patch. I wrote new patch that uses
>malloc instead.

Sorry I haven't had time to look into refactoring this patch more. However
Pengcheng has volunteered to clean it up in whatever way is acceptable.

The caveat with using malloc is that I would expect it to be significantly
slower than alloca, but someone can benchmark that. I believe this is a
hot path.

-Deb


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]