This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH][BZ #15698] Fix memory overrun in getifaddrs_internal.
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org, hjl dot tools at gmail dot com
- Date: Tue, 14 Jan 2014 14:11:47 +0100
- Subject: Re: [PATCH][BZ #15698] Fix memory overrun in getifaddrs_internal.
- Authentication-results: sourceware.org; auth=none
- References: <20131008165738 dot GA14975 at domone dot podge> <201401111335 dot 32137 dot vapier at gentoo dot org>
On Sat, Jan 11, 2014 at 01:35:30PM -0500, Mike Frysinger wrote:
> On Tuesday 08 October 2013 12:57:38 OndÅej BÃlka wrote:
> > Hi, a code at https://sourceware.org/bugzilla/show_bug.cgi?id=15698
> > contains a simple off-by-one error when preflen is divisible by 8.
> >
> > Following code should fix this, as preflen is unsigned I added check for
> > zero len to be sure we do not cause underflow.
> >
> > OK to commit?
>
> test case ?
> -mike
That is difficult, after browsing code a prefixlen is read from kernel
netlink interface. To trigger this bug we would need to create a dummy
interface which needs root.