This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: i686/memmove.S always copies backwards when dst > src
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Maxim Kuvyrkov <maxim at kugelworks dot com>
- Cc: Yuriy Kaminskiy <yumkam at gmail dot com>, GLIBC Devel <libc-alpha at sourceware dot org>
- Date: Tue, 7 Jan 2014 20:40:10 +0100
- Subject: Re: i686/memmove.S always copies backwards when dst > src
- Authentication-results: sourceware.org; auth=none
- References: <l97qbr$m1$1 at ger dot gmane dot org> <956CAFFD-2EA0-4AAB-BC41-94EA0D5531D4 at kugelworks dot com> <l98vji$ufi$1 at ger dot gmane dot org> <20140102201711 dot GD25179 at domone> <58050FE6-2453-41F1-B09A-1F600F1E5829 at kugelworks dot com> <20140107182348 dot GC10455 at domone dot podge> <72CC2010-B750-4156-AE19-EC0F880F0371 at kugelworks dot com>
On Wed, Jan 08, 2014 at 08:20:02AM +1300, Maxim Kuvyrkov wrote:
> On 8/01/2014, at 7:23 am, OndÅej BÃlka <neleai@seznam.cz> wrote:
>
> > On Tue, Jan 07, 2014 at 02:20:47PM +1300, Maxim Kuvyrkov wrote:
> ...
> >>
> >> I've created BZ #16394. The attached patch was tested in i686 environment with memmove ifunc forced to resolve to implementation in sysdeps/i386/i686/memmove.S.
> >>
> >> I will check in the patch in 24 hours since at least 3 developers have looked at it and confirmed that it is the right fix.
> >>
> >> Thanks,
> >>
> > As I said above it looks correct, who else?
>
> You, Yuriy and myself. Also, I've spent a good deal of time in the debugger to confirm that the bug cannot trigger wrong behavior, and managed to convince myself of that.
>
Yeah, I did not count yourself so I bit wondered.