Re: automatically updating ulps -- any review needed ?

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 06 January 2014 09:24:54 Joseph S. Myers wrote:
> On Sun, 5 Jan 2014, Mike Frysinger wrote:
> > the ia64 code hasn't had its ulps file regenerated in a long time.  i
> > used the helper target for regenerating things, and now i'm looking at
> > the diff.  but i
> 
> Note that the checked-in file should be truncated before running "make
> regen-ulps", so as to remove old ulps for tests for which errors have gone
> down or whose names have changed.

thanks, i've committed an update that deletes old entries and lowers ULPs for 
some others

> In the file you've checked in, the only major problems appear to be for
> pow:
> 
> Function: "pow":
> float: 4194304
> ifloat: 4194304
> 
> Function: "pow_tonearest":
> float: 4194304
> ifloat: 4194304
> 
> For those, you should (a) file a bug in Bugzilla for the problem,
> identifying the specific tests with large errors (showing the expected and
> actual results from test-float.out), (b) either fix the bug, or mark the
> tests as expected to fail in auto-libm-test-in (xfail:flt-32:ia64, say,
> with an associated definition of TEST_COND_ia64 in libm-test.inc) and
> regenerate auto-libm-test-out, (c) truncate and regenerate libm-test-ulps.

i've deleted the pow entries and opened bug 16401 on the topic

> Although, there are also ulps for ctanh that seem a bit high:
> 
> Function: Imaginary part of "ctanh":
> ildouble: 24
> ldouble: 24
> 
> But those look like a test that's since changed its name - so truncating
> the file before regenerating should eliminate those.

truncating the file made those entries go away.  ignoring the pow issue, looks 
like the highest now is 7.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.