Re: [PATCH 1/4] Add _dl_{mask,unmask}_all_signals

[Mike Frysinger <vapier at gentoo dot org>]

On Friday 20 December 2013 12:40:51 Paul Pluzhnikov wrote:
> On 12/20/13, 2:53 AM, Thomas Schwinge wrote:
> > This got pushed as commit 69a17d9d245dc3551792e95e1823cc2d877592f3; the
> > ChangeLog shows Andrew as the author, but the Git author entry shows
> > Paul?
> 
> Is the standard procedure here to supply '--author=Andrew Hunter
> <ahh@google.com>' to git-commit?

the standard procedure is to use `git am` to apply patches from the mailing 
list.  that will preserve the author information.  you shouldn't override it 
with your own --author.

if you apply the patch by hand (for some weird reason), then you do need to 
take care to fix the --author manually.  but just use `git am` and it's a non 
issue.

another problem though with the commit: you didn't preserve the commit 
message.  the ChangeLog entry was pasted instead.  omit the ChangeLog content 
and use the standard git commit instead (what Andrew had posted in his email).  
you can compare 7f507ee17aee720fa423fa38502bc3caa0dd03d7 and 
19f6b98b55b9bd3c8cad4c22212efdb7545752f2 to see what i mean.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.