This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] tst-longjmp_chk2: add comments/sanity check
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: <libc-alpha at sourceware dot org>
- Date: Mon, 30 Dec 2013 14:07:44 +0000
- Subject: Re: [PATCH] tst-longjmp_chk2: add comments/sanity check
- Authentication-results: sourceware.org; auth=none
- References: <1388352685-11157-1-git-send-email-vapier at gentoo dot org>
On Sun, 29 Dec 2013, Mike Frysinger wrote:
> + /* Sanity check to keep test from looping forever (in case the longjmp
> + chk code is slightly broken). */
> + assert (pass++ < 5);
Side effects inside an argument to assert don't seem a particularly good
idea, even if we don't expect tests to use -DNDEBUG....
--
Joseph S. Myers
joseph@codesourcery.com