This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: Move various TEST_c_c tests from libm-test.inc to auto-libm-test-inc
- From: Andreas Jaeger <aj at suse dot com>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>, libc-alpha at sourceware dot org
- Date: Fri, 20 Dec 2013 10:37:18 +0100
- Subject: Re: Move various TEST_c_c tests from libm-test.inc to auto-libm-test-inc
- Authentication-results: sourceware.org; auth=none
- References: <Pine dot LNX dot 4 dot 64 dot 1312192320130 dot 20444 at digraph dot polyomino dot org dot uk>
On 12/20/2013 12:23 AM, Joseph S. Myers wrote:
> This patch moves tests of ccos, ccosh, cexp, clog, csqrt, ctan and
> ctanh to auto-libm-test-in, adding the required support to
> gen-auto-libm-tests. Other TEST_c_c functions aren't moved for now
> (although the relevant table entries are put in gen-auto-libm-tests
> for it to know how to handle them): clog10 because of a known MPC bug
> causing it to hang for at least some pure imaginary inputs (fixed in
> SVN, but I'd rather not rely on unreleased versions of MPFR or MPC
> even if relying on very recent releases); the inverse trig and
> hyperbolic functions because of known slowness in special cases; and
> csin / csinh because of observed slowness that I need to investigate
> and report to the MPC maintainers. Slowness can be bypassed by moving
> to incremental generation (only for new / changed tests) rather than
> regenerating the whole of auto-libm-test-out every time, but that
> needs implementing. (This patch takes the time for running
> gen-auto-libm-tests from about one second to seven, on my system,
> which I think is reasonable. The slow functions would make it take
> several minutes at least, which seems unreasonable.)
I agree with your handling of the slow functions.
The patch is fine, thanks.
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126