Re: [WIP] Remove nested function in elf/dl-lookup.c? (Nested functions considered harmful?)

[Mike Frysinger <vapier at gentoo dot org>]

On Monday 16 December 2013 14:57:27 Andreas Jaeger wrote:
> On 12/16/2013 05:51 PM, Mike Frysinger wrote:
> > [...]
> > have i mentioned i fsckin hate the glibc commit history ?  current
> > history sometimes isn't too much better.
> 
> Please speak up if you see recent examples. While we cannot change the
> past, we should learn from it and improve for the future...

Joseph writes great summaries on the list, but the commit messages strip out 
everything but the subject line.  he isn't the only one, but he's probably the 
most prolific and stark contrast between the two.

git message:
	commit e47cc4e0ed06f4167b6bd8ac39e12d094e0dc474
	Author: Joseph Myers <joseph@codesourcery.com>
	Date:   Thu Dec 5 14:01:41 2013 +0000

	    Fix tgamma errno setting on underflow (bug 6810).
as compared to the mailing list posting:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00184.html

git message:
	commit bbf37bdc12c0370a0ac2fa597cddd660bad6ec5e
	Author: Joseph Myers <joseph@codesourcery.com>
	Date:   Thu Dec 5 13:54:50 2013 +0000

	    Move TEST_f_f tests for [l-y]* functions from libm-test.inc to auto-
libm-test-in.
as compared to the mailing list posting:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00183.html

there are other examples:
	commit 7a74607ff632054cbf915179c4b4735be009694f
	Author: Siddhesh Poyarekar <siddhesh@redhat.com>
	Date:   Wed Dec 11 12:08:19 2013 +0530

	    Consolidate definition of constant t22
as compared to the mailing list posting:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00450.html

this:
	commit 196f7f5dbfe3019379934ab39ca8b7ef1d92add5
	Author: Siddhesh Poyarekar <siddhesh@redhat.com>
	Date:   Wed Dec 11 11:24:25 2013 +0530

	    Use double constants instead of the struct number
vs:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00191.html

this:
	commit 5782a80f9f8ca86899b30161166f044b0b6b8590
	Author: OndÅej BÃlka <neleai@seznam.cz>
	Date:   Tue Dec 10 17:56:59 2013 +0100

	    Drop PER_THREAD conditionals from malloc.
vs:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00228.html

this:
	commit e8349efd466cfedc0aa98be61d88ca8795c9e565
	Author: OndÅej BÃlka <neleai@seznam.cz>
	Date:   Mon Dec 9 17:25:19 2013 +0100

	    Simplify perturb_byte logic.
vs:
	https://sourceware.org/ml/libc-alpha/2013-12/msg00299.html

various thoughts/justifications/musings are useful in commit messages when 
mining history.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.