This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: build for sh fails with "fanotify_mark@@VERSION_libc_er"


On 12/11/2013 11:50 PM, Kaz Kojima wrote:
> Roland McGrath <roland@hack.frob.com> wrote:
>> Your fix is correct (and obvious enough).  
>> What's surprising is that this wasn't breaking any other case.
> 
> Is it OK as an obvious fix with the ChangeLog entry below?
> 
> 2013-12-12  Kaz Kojima  <kkojima@rr.iij4u.or.jp>
> 
> 	* sysdeps/unix/Makefile ($(objpfx)stub-syscalls.c): Double $ in
> 	command.

Suggest:

	* sysdeps/unix/Makefile ($(objpfx)stub-syscalls.c): Use $$ver.

OK with that.

Thankfully this broke only just recently at 2013-09-11 by
0a834ddecbb08b79cbcf7d9460ab3d3d539c9962. So there has been no
release with this fix for removing bash-isms.

My gut says that on all other targets we probably don't have
any stubs so this never showed up because this code was never
called. Every other architecture probably has fanotify_mark
generated by a syscall wrapper, not a syscall stub.

So the followup question is why does sh use a do-nothing
stub for this?

Cheers,
Carlos.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]