This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Replace malloc force_reg by atomic_forced_read.
- From: Will Newton <will dot newton at linaro dot org>
- To: Ondřej Bílka <neleai at seznam dot cz>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 9 Dec 2013 15:44:08 +0000
- Subject: Re: [PATCH] Replace malloc force_reg by atomic_forced_read.
- Authentication-results: sourceware.org; auth=none
- References: <20131209134609 dot GA22876 at domone dot podge>
On 9 December 2013 13:46, OndÅej BÃlka <neleai@seznam.cz> wrote:
> Hi,
>
> this refactors a malloc a bit, macro force_reg is a duplicate of
> atomic_forced_read so we use it instead.
>
> OK to commit?
>
> * malloc/malloc.c: (force_reg): Remove.
> (__malloc_assert, __libc_malloc, __libc_free, __libc_realloc,
> _mid_memalign, __libc_calloc): replace force_reg by atomic_forced_read.
> * malloc/arena.c (ptmalloc_init): Likewise.
> * malloc/hooks.c (top_check): Likewise.
>
This looks ok to me. Should be a capital R in replace in the changelog
entry though and should mention sysmalloc and systrim.
--
Will Newton
Toolchain Working Group, Linaro