This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/4] getaddrinfo: Remove unnecessary variables and code
- From: OndÅej BÃlka <neleai at seznam dot cz>
- To: Pavel Simerda <psimerda at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>, Siddhesh Poyarekar <siddhesh at redhat dot com>
- Date: Mon, 9 Dec 2013 16:27:10 +0100
- Subject: Re: [PATCH 1/4] getaddrinfo: Remove unnecessary variables and code
- Authentication-results: sourceware.org; auth=none
- References: <860551836 dot 23953523 dot 1386596222016 dot JavaMail dot root at redhat dot com> <841948625 dot 23953604 dot 1386596238564 dot JavaMail dot root at redhat dot com>
On Mon, Dec 09, 2013 at 08:37:18AM -0500, Pavel Simerda wrote:
> Variable 'end' in getaddrinfo() was only used to compute 'nresults'
> which was already computed in gaih_inet() and stored in 'naddrs'.
>
This needs know code in detail, it looks similir but I there is
following fragment that may mak these differ
/* If we looked up IPv4 mapped address discard them here if
the caller isn't interested in all address and we have
found at least one IPv6 address. */
if (got_ipv6
&& (req->ai_flags & (AI_V4MAPPED|AI_ALL)) == AI_V4MAPPED
&& IN6_IS_ADDR_V4MAPPED (at2->addr))
goto ignore;
> Variable 'last_i' was used at the end of getaddrinfo() even though
> it was always zero.
>
ok with last_i part.