This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] getaddrinfo: remove dead code
- From: Siddhesh Poyarekar <siddhesh at redhat dot com>
- To: Pavel Simerda <psimerda at redhat dot com>
- Cc: libc-alpha <libc-alpha at sourceware dot org>
- Date: Mon, 2 Dec 2013 14:54:48 +0530
- Subject: Re: [PATCH] getaddrinfo: remove dead code
- Authentication-results: sourceware.org; auth=none
- References: <330673576 dot 18908039 dot 1385400605589 dot JavaMail dot root at redhat dot com> <907724588 dot 18908775 dot 1385400786577 dot JavaMail dot root at redhat dot com>
On Mon, Nov 25, 2013 at 12:33:06PM -0500, Pavel Simerda wrote:
> Hi,
>
> some time ago I found a couple of lines in getaddrinfo.c that are redundant. Posting now.
>
> Cheers,
>
> Pavel
>
> * sysdeps/posix/getaddrinfo.c: Remove dead code.
The ChangeLog entry is incorrect. It should be:
* sysdeps/posix/getaddrinfo.c (UNIX_PATH_MAX): Remove macro.
(struct gaih): Remove definition.
OK otherwise. I'll commit it shortly.
Thanks,
Siddhesh
>
> diff --git a/sysdeps/posix/getaddrinfo.c b/sysdeps/posix/getaddrinfo.c
> index 8ff74b4..387c22f 100644
> --- a/sysdeps/posix/getaddrinfo.c
> +++ b/sysdeps/posix/getaddrinfo.c
> @@ -74,10 +74,6 @@ extern int __idna_to_unicode_lzlz (const char *input, char **output,
> #define GAIH_OKIFUNSPEC 0x0100
> #define GAIH_EAI ~(GAIH_OKIFUNSPEC)
>
> -#ifndef UNIX_PATH_MAX
> -# define UNIX_PATH_MAX 108
> -#endif
> -
> struct gaih_service
> {
> const char *name;
> @@ -127,14 +123,6 @@ static const struct gaih_typeproto gaih_inet_typeproto[] =
> { 0, 0, 0, false, "" }
> };
>
> -struct gaih
> - {
> - int family;
> - int (*gaih)(const char *name, const struct gaih_service *service,
> - const struct addrinfo *req, struct addrinfo **pai,
> - unsigned int *naddrs);
> - };
> -
> static const struct addrinfo default_hints =
> {
> .ai_flags = AI_DEFAULT,