This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH 1/2] MIPS: Add wrappers to get/setrlimit64 to fix RLIM64_INFINITY constant
- From: Aurelien Jarno <aurelien at aurel32 dot net>
- To: "Joseph S. Myers" <joseph at codesourcery dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 26 Nov 2013 21:38:00 +0100
- Subject: Re: [PATCH 1/2] MIPS: Add wrappers to get/setrlimit64 to fix RLIM64_INFINITY constant
- Authentication-results: sourceware.org; auth=none
- References: <1385225032-2690-1-git-send-email-aurelien at aurel32 dot net> <1385225032-2690-2-git-send-email-aurelien at aurel32 dot net> <Pine dot LNX dot 4 dot 64 dot 1311261626450 dot 25885 at digraph dot polyomino dot org dot uk>
On Tue, Nov 26, 2013 at 04:30:58PM +0000, Joseph S. Myers wrote:
> On Sat, 23 Nov 2013, Aurelien Jarno wrote:
>
> > +# define libc_hidden_def(name) hidden_def(name)
>
> Missing space after "hidden_def".
>
> > +/* RLIM64_INFINITY was supposed to be a glibc convention rather than
> > + * anything seen by the kernel, but it ended being passed to the kernel
> > + * through the prlimit64 syscall. Given that a lot of binaries with
> > + * the wrong constant value are in the wild, provide a wrapper function
> > + * fixing the value after the syscall. */
>
> No leading "*" on comment continuation lines.
>
> > + if (__internal_getrlimit64(resource, &krlimits) < 0)
>
> Missing space before "(".
>
> > +libc_hidden_def(getrlimit64)
>
> Missing space.
>
> > +#else /* !_ABI_O32 && !_ABI_N32*/
>
> Missing space before end of comment.
>
> > + return __internal_setrlimit64(resource, &krlimits);
>
> Missing space.
>
> This patch is OK with those things fixed if it's been tested without any
> local patches disabling parts of the testsuite.
>
Thanks for the review, I'll fix the issues in the next version of the patch.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net