This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/2] Define PTR_MANGLE and PTR_DEMANGLE unconditionally.


On 11/06/2013 07:24 AM, OndÅej BÃlka wrote:
> On Tue, Nov 05, 2013 at 07:11:49PM +0100, Andreas Schwab wrote:
>> OndÅej BÃlka <neleai@seznam.cz> writes:
>>
>>> Moving these would involve creating a new header. A posibility would be
>>> a defaults header where we would move various compatibility definitions.
>>
>> That file could be sysdeps/generic/sysdep.h.
>>
> We should first make clear ordering issues. As for PTR_MANGLE a generic
> comes before PTR_MANGLE is defined so we need extra undef before each
> definition.
> 
> With file included as last these will not be needed.
> 
> Also when we expand this I am bit afraid of inconsistencies when half
> can be defined before this file and other half after it is included.

What inconsistencies would there be?

It is true that we might need #undef FOO before you define your own,
but that's normal for all macros that have early defined defaults and
it's not bad as fars I care.

Cheers,
Carlos.
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]