This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
| Other format: | [Raw text] | |
On 10/01/2013 04:16 PM, Roland McGrath wrote: > I don't see any problem but it's not handy right now for me to read all the > context of the function to be sure it's complete. I'm also not very > motivated to do that review since this is code that won't ever be used in > libc. I'd be happiest if a gnulib maintainer reviews and signs off on the > change and a thorough test case goes into gnulib. Then I'll be happy just > to verify the style trivia and approve it to go into libc. I _am_ a gnulib maintainer, and this patch has already been in gnulib, with tests, for 3 years now. http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-canonicalize.c#n307 http://git.savannah.gnu.org/cgit/gnulib.git/commit/tests/test-canonicalize.c?id=35bd2ff772 -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
| Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
|---|---|---|
| Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |