This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Consolidate some common code in s_sin.c
- From: Andreas Jaeger <aj at suse dot com>
- To: Siddhesh Poyarekar <siddhesh at redhat dot com>
- Cc: libc-alpha at sourceware dot org
- Date: Thu, 19 Sep 2013 15:06:12 +0200
- Subject: Re: [PATCH] Consolidate some common code in s_sin.c
- Authentication-results: sourceware.org; auth=none
- References: <20130918072750 dot GL13304 at spoyarek dot pnq dot redhat dot com> <523AC52A dot 6010904 at suse dot com> <20130919100520 dot GT13304 at spoyarek dot pnq dot redhat dot com> <523ACDD8 dot 3020300 at suse dot com> <20130919111004 dot GU13304 at spoyarek dot pnq dot redhat dot com>
On 09/19/2013 01:10 PM, Siddhesh Poyarekar wrote:
> On Thu, Sep 19, 2013 at 12:11:36PM +0200, Andreas Jaeger wrote:
>> On 09/19/2013 12:05 PM, Siddhesh Poyarekar wrote:
>>> On Thu, Sep 19, 2013 at 11:34:34AM +0200, Andreas Jaeger wrote:
>>>>
>>>> Could you add some comments on what these macros compute? I know the
>>>> original code is rather uncommented...
>>>>
>>>
>>> TBH, I haven't tried to figured out the exact polynomial computation
>>> that's happening here - my intention was to get common bits out first
>>> and then try to figure out what those bits mean mathematically. I
>>> guess I have to figure it out eventually, so I'll post an updated
>>> patch with the comment once I figure it out.
>>
>> Ok, thanks,
>
> Here's an updated patch with comments.
>
Thanks, this is great,
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126