This is the mail archive of the libc-alpha@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Consolidate some common code in s_sin.c


On 09/19/2013 01:10 PM, Siddhesh Poyarekar wrote:
> On Thu, Sep 19, 2013 at 12:11:36PM +0200, Andreas Jaeger wrote:
>> On 09/19/2013 12:05 PM, Siddhesh Poyarekar wrote:
>>> On Thu, Sep 19, 2013 at 11:34:34AM +0200, Andreas Jaeger wrote:
>>>>
>>>> Could you add some comments on what these macros compute? I know the
>>>> original code is rather uncommented...
>>>>
>>>
>>> TBH, I haven't tried to figured out the exact polynomial computation
>>> that's happening here - my intention was to get common bits out first
>>> and then try to figure out what those bits mean mathematically.  I
>>> guess I have to figure it out eventually, so I'll post an updated
>>> patch with the comment once I figure it out.
>>
>> Ok, thanks,
> 
> Here's an updated patch with comments.
> 

Thanks, this is great,

Andreas
-- 
 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
    GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]