This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [PATCH] Don't use Bash-specific ${parameter/pattern/string} expansion
- From: "Patrick 'P. J.' McDermott" <pj+sourceware-ml at pehjota dot net>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: libc-alpha at sourceware dot org
- Date: Tue, 10 Sep 2013 12:58:30 -0400
- Subject: Re: [PATCH] Don't use Bash-specific ${parameter/pattern/string} expansion
- Authentication-results: sourceware.org; auth=none
- References: <522CDBAD dot 8000104 at pehjota dot net> <201309101124 dot 51598 dot vapier at gentoo dot org>
On 2013-09-10 11:24, Mike Frysinger wrote:
> On Sunday 08 September 2013 16:18:53 Patrick 'P. J.' McDermott wrote:
>> case $$call in \
>> *@@*) \
>> - ver=$${call##*@}; call=$${call%%@*}; ver=$${ver//./_}; \
>> + ver=$${call##*@}; call=$${call%%@*}; \
>> + ver=`echo $ver | sed 's/\./_/g'`; \
>
> you need to quote "$ver"
AFAIK, $ver should never contain any IFS characters. But yes, quoting
would generally be safer. I'll do that.
Thanks,
--
Patrick "P. J." McDermott
http://www.pehjota.net/
Lead Developer, ProteanOS
http://www.proteanos.com/